Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Allow customization of PubSubReactiveFactory's maxMessages property. #2451

Open
elefeint opened this issue Jun 26, 2020 · 1 comment
Open

Comments

@elefeint
Copy link
Contributor

elefeint commented Jun 26, 2020

As of #2441, PubSubReactiveFactory's constructor accepts maxMessages for requesting a batch of messages up to this number when polling Cloud Pub/Sub.

We should introduce a property spring.cloud.gcp.pubsub.reactive.polled-message-batch-size to customize the autoconfigured setting in GcpPubSubReactiveAutoConfiguration. Feel free to come up with a better name than polled-message-batch-size.

This will require creating a new properties class org.springframework.cloud.gcp.autoconfigure.GcpPubSubReactiveProperties, and using it in GcpPubSubReactiveAutoConfiguration.

Additionally, the new property will need to be added to documentation

@elefeint elefeint changed the title Add property Allow customization of PubSubReactiveFactory's maxMessages property. Jun 26, 2020
@meltsufin
Copy link
Contributor

You can have a property by itself as well, without a class. We already do this for spring.cloud.gcp.pubsub.reactive.enabled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants