Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Prometheus RSocket Proxy Properties should be forwarded from server to task applications #5856

Open
klopfdreh opened this issue Jul 2, 2024 · 0 comments
Labels
type/enhancement Is an enhancement request
Milestone

Comments

@klopfdreh
Copy link
Contributor

Description:
When we tested the Prometheus RSocket Proxy functionality of SCDF we saw that the following properties are forwarded / created from SCDF:

management.prometheus.metrics.export.*
management.metrics.export.prometheus.*

With 2.0.0-M1 of Prometheus RSocket Proxy however there are new properties which also should be forwarded to all task applications if definied in the server yml:

micrometer.prometheus.rsocket.*

See: https://github.com/micrometer-metrics/prometheus-rsocket-proxy/blob/6cd90c97655763f3641ed1b0106e4a79a6b2b0e9/starter-spring/src/main/java/io/micrometer/prometheus/rsocket/autoconfigure/PrometheusRSocketClientProperties.java#L28

Release versions:
2.11.x

Custom apps:
N/A

Steps to reproduce:
Just start a task application with prometheus rsocket proxy client via a SCDF server which defines the new properties

Screenshots:
N/A

Additional context:
Workaround: Create a config map which is mounted into all task applications via platform.kubernetes.accounts.default.* and define the following env vars:

MICROMETER_PROMETHEUS_RSOCKET_ENABLED: "true"
MICROMETER_PROMETHEUS_RSOCKET_HOST: "myhostname"
MICROMETER_PROMETHEUS_RSOCKET_PORT: "7001"
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jul 2, 2024
@cppwfs cppwfs removed the status/need-triage Team needs to triage and take a first look label Jul 2, 2024
@cppwfs cppwfs added this to the 2.11.5 milestone Jul 2, 2024
@corneil corneil added the type/enhancement Is an enhancement request label Jul 30, 2024
@cppwfs cppwfs modified the milestones: 2.11.5, 3.0.x Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Is an enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants