Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Configure HTTP Resource Factories on Jetty and Reactor servers #14495

Closed
bclozel opened this issue Sep 17, 2018 · 2 comments
Closed

Auto-Configure HTTP Resource Factories on Jetty and Reactor servers #14495

bclozel opened this issue Sep 17, 2018 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Sep 17, 2018

#14058 introduced the auto-configuration of HTTP resource factories for Jetty and Reactor Netty based clients. With that, developers can customize those HTTP resources and we make sure that they're tied to the application lifecycle.

This issue is about taking the same resources and configuring them on the server side as well.

@bclozel bclozel added the type: enhancement A general enhancement label Sep 17, 2018
@bclozel bclozel added this to the 2.1.0.RC1 milestone Sep 17, 2018
@bclozel bclozel self-assigned this Sep 17, 2018
@bclozel
Copy link
Member Author

bclozel commented Sep 17, 2018

@rstoyanchev, does that description fits our discussion?

If we do that, server and clients configured by Spring Boot will always share the resources created by those factories. The only way to get around that would be to manually WebClient.create() a client instance.

I'm fine with that state of things but I was wondering if this sounds good to you.

@rstoyanchev
Copy link
Contributor

@bclozel that sounds right. For Reactor Netty, client and server already used to share the global resources before #14058 so in a way this would restore the previous arrangement. As for deviating from that model, couldn't one inject WebClient.Builder and then change the connector?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants