-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use StackWalker to deduce main application class #31665
Labels
Comments
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Jul 11, 2022
wilkinsona
changed the title
Refactor org.springframework.boot.SpringApplication#deduceMainApplicationClass method with jep259
Use StackWalker to deduce main application class
Jul 12, 2022
Thanks very much for the suggestion, @GGGGGHT. Would you like to open a pull request for this change? |
wilkinsona
added
type: task
A general task
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Jul 12, 2022
wilkinsona
added
the
status: waiting-for-feedback
We need additional information before we can continue
label
Jul 12, 2022
Ofcourse,it's my pleasure. |
spring-projects-issues
added
status: feedback-provided
Feedback has been provided
and removed
status: waiting-for-feedback
We need additional information before we can continue
labels
Jul 13, 2022
Thank you. I'll close this in favor of your PR. |
wilkinsona
added
status: superseded
An issue that has been superseded by another
and removed
status: feedback-provided
Feedback has been provided
labels
Jul 13, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Recently I am learning new features after jdk9, I saw an interesting feature. Stack-Walking API.
This API allows us to iterator the current stack in a streaming fashion. So I want to use this method to rewrite the deduceMainApplicationClass method. This will make the code look more concise.
This method can be optimized like this:
JMH demo
Here are the results of a benchmark I did with hotspot17 and jmh. The complete information I put in the file below.
The text was updated successfully, but these errors were encountered: