Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate CheckStyle checks in PR build #22487

Closed
ledoyen opened this issue Feb 27, 2019 · 2 comments
Closed

Integrate CheckStyle checks in PR build #22487

ledoyen opened this issue Feb 27, 2019 · 2 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@ledoyen
Copy link
Contributor

ledoyen commented Feb 27, 2019

Today, when submitting a PR, there is no community feedback if proposed code does not comply with checkstyle rules.

Only the core team can detect such an oversight and provides a feedback to external commiters.
It is time consuming for the core team (I assume 😄), and does not avoid code containing new violations from being merged.

A quick action could be to integrate a Travis build running gradle check to PR workflow.
@ledoyen ledoyen mentioned this issue Feb 27, 2019
Merged
5 tasks
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 27, 2019
@snicoll
Copy link
Member

snicoll commented Feb 28, 2019

@ledoyen thanks for the feedback, we intend to move to concourse and add a pipeline to build pull requests.

@snicoll
Copy link
Member

snicoll commented Feb 28, 2019

Superseded by #22490

@snicoll snicoll closed this as completed Feb 28, 2019
@snicoll snicoll added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 28, 2019
@sbrannen sbrannen changed the title Integrates checkstyle build in PR checks Integrate CheckStyle checks in PR build Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snicoll @ledoyen @spring-projects-issues