Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for permalinks #1045

Closed
SimonSiefke opened this issue Aug 13, 2024 · 2 comments
Closed

support for permalinks #1045

SimonSiefke opened this issue Aug 13, 2024 · 2 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@SimonSiefke
Copy link

GraphiQL allows users to generate permalinks for specific queries, enabling easy sharing and revisiting of GraphQL operations. This feature is very useful for debugging and documentation, as it allows queries and variables to be encoded directly in the URL (e.g., GraphiQL SWAPI Example).

graphql2

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 13, 2024
@bclozel
Copy link
Member

bclozel commented Aug 20, 2024

As far as I can see there is no GraphiQL plugin that does this and this is powered by inline JavaScript on that instance.
I'm not against it, but I would understand if some developers would be annoyed by an ever changing URL in the address bar of their browser.

We'll discuss that as a team.
If other community members have an opinions about this, please comment on this issue.

@bclozel bclozel added the for: team-attention An issue we need to discuss as a team to make progress label Aug 20, 2024
@bclozel
Copy link
Member

bclozel commented Sep 5, 2024

We have discussed this as a team today and we're going to decline this enhancement request.

Our GraphiQL default setup should be minimal and only rely on well-known plugins maintained by the community. This particular feature is managed by inline JS (you can check it out by using "show source" on that page) that's easily reusable with your own GraphiQL setup.

Thanks for this proposal!

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
@bclozel bclozel added type: enhancement A general enhancement status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged for: team-attention An issue we need to discuss as a team to make progress labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants