QueryDSL does not work with Extended Validation

[Thinkenterprise]

I work with Spring Boot 2.6 and Spring GraphQL 1.0.0-M4.

Spring GraphQL supports Jakarta Bean Validation, and it works too.

I still tried the validation via DIRECTIVES and their implementation. That works too!!

<dependency>
	<groupId>com.graphql-java</groupId>
	<artifactId>graphql-java-extended-validation</artifactId>
	<version>17.0-hibernate-validator-6.2.0.Final</version>
</dependency>

However, if I add the following configuration, the QueryDSL repositories no longer work and return a value of null.

@Profile("validation")
@Configuration
public class GraphQLValidationConfiguration implements RuntimeWiringConfigurer {

    @Override
    public void configure(Builder builder) {
        ValidationRules validationRules = ValidationRules.newValidationRules()
                                                         .onValidationErrorStrategy(OnValidationErrorStrategy.RETURN_NULL)
                                                        .build();
       ValidationSchemaWiring validationSchemaWiring = new  ValidationSchemaWiring(validationRules);
       builder.directiveWiring(validationSchemaWiring);
    }
}

I also added the configuration and dependency to the Spring GraphQL sample and there are problems there too. So, it seems to be a general problem and not a problem in my implementation!?

I am not sure whether this is a mistake in the implementation of the various QueryDSLDataFetcher or whether it is due to the graphql-java-extended-validation

I just want to communicate the problem and let the Spring GraphQL team decide. Thanks

[bclozel]

Could you provide a sample application showing the problem? Ideally, something we can download or a project on github we could git clone. So far, I don't see anything specific to Spring GraphQL so we'd need to see the problem for ourselves to figure things out.

[Thinkenterprise]

Yes very much. I have pushed the small example based on your webmvc-http-sample into my github account. If you start the application the query

query {
  artifactRepositories {
    id
  }
}

doese not return any data. If you disable the GraphQLConfiguration the same query works.

[rstoyanchev]

Looking at extended validation, ValidationSchemaWiring decorates the DataFetcher for each field, but the auto-registration for QueryDSL and QBE happens late, through a TypeVisitor after each RuntimeWiringConfigurer, and only if there isn't a registration already, that is other than a PropertyDataFetcher. As a result of this, such a decorated PropertyDataFetcher likely causes the QueryDSL auto-registration to back off.

I don't know yet what a solution might be but we can review the order in which we perform registrations in GraphQlSource.Builder in light of this.

[rstoyanchev]

@Thinkenterprise, the way auto registration works has been updated to be more reliable and work better with other ways of registerting data fetchers. It's now based on a WiringFactory which is applied when deciding on the DataFetcher for a field, and before Extended Validation's decoration via SchemaDirectiveWiring.

So this should be fixed, if you'd like you can give it a try with 1.0.0-SNAPSHOT and Boot 2.7.0-SNAPSHOT for the starter.

[Thinkenterprise]

@rstoyanchev I checked it works. Thanks!!

[rstoyanchev]

Good to hear and thanks for the quick confirmation!