Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ping and Pong messages from the GraphQL over WebSocket protocol #267

Closed
RunCMD159 opened this issue Jan 23, 2022 · 2 comments
Closed

Support Ping and Pong messages from the GraphQL over WebSocket protocol #267

RunCMD159 opened this issue Jan 23, 2022 · 2 comments
Labels
in: web Issues related to web handling type: enhancement A general enhancement

Comments

@RunCMD159
Copy link

RunCMD159 commented Jan 23, 2022 •
edited
Loading

Hi,
I just refactored my existing graphql-java server to a spring-graphql implementation.
But somehow my websocket connection always terminates with invalid message as soon as my apollo-angular client sends an automatic ping messages.
I saw that ping/pong is not a supported messagetype in the GraphQLWebsocketHandler.

Am I missing something here?
How should i handle ping/pong messages with spring-graphql?

Thank you in advance
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 23, 2022
@rstoyanchev
Copy link
Contributor

This was added to the protocol later so it's just missing.

@rstoyanchev rstoyanchev added in: web Issues related to web handling type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 1, 2022
@rstoyanchev rstoyanchev added this to the 1.0 Backlog milestone Feb 1, 2022
@rstoyanchev rstoyanchev changed the title Handle websocket ping/pong messages Support Ping and Pong messages from the GraphQL over WebSocket protocol Feb 1, 2022
@rstoyanchev rstoyanchev linked a pull request Feb 1, 2022 that will close this issue
Support for GraphQL over WebSocket Ping and Pong message types #270
Closed
@rstoyanchev
Copy link
Contributor

Superseded by #270.

@rstoyanchev rstoyanchev removed this from the 1.0 Backlog milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web Issues related to web handling type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for GraphQL over WebSocket Ping and Pong message types
3 participants
@rstoyanchev @RunCMD159 @spring-projects-issues