Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] Could sample webmvc-websocket be provided? #473

Closed
GoncaloPT opened this issue Aug 25, 2022 · 2 comments
Closed

[Sample] Could sample webmvc-websocket be provided? #473

GoncaloPT opened this issue Aug 25, 2022 · 2 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@GoncaloPT
Copy link

Hi,
Thanks for the great work.

In the docs we see the reference for a webmvc + websocket setup, but it is very unclear how would such be setup.
The content if found ( including josh's videos ) always use webflux(Flux,Mono).

Therefore, if this setup is even possible, It would be very helpful to have a simple example.
Thanks!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 25, 2022
@GoncaloPT
Copy link
Author

After some digging, I found that it isn't that different - in terms of setup - from webflux-websocket.
I will later create a PR with the requested example in order to help people that had the same doubt as me.

@bclozel
Copy link
Member

bclozel commented Aug 25, 2022

Thanks for the update @GoncaloPT .
Don't bother with a PR, we're in the process of deciding what to do with the samples folder in this repository. Right now this is creating a dependency cycle between Spring Boot and Spring for GraphQL, so we might take it out completely and turn it into one or several guides on spring.io.

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2022
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

3 participants