Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support controller method parameter annotations on an interface #480

Closed
JamesPeters98 opened this issue Sep 5, 2022 · 0 comments
Closed
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@JamesPeters98
Copy link

JamesPeters98 commented Sep 5, 2022

It's currently not possible to define interfaces with the @Argument parameter annotation.

i,e:

interface HelloWorld {
  @QueryMapping
  String helloWorld(@Argument String name);
}
@Controller
class HelloWorldImpl implements HelloWorld {
  @Override
  String helloWorld(String name) {
    return "Hello "+name;
  }
}

This doesn't work and requires the implementation to also be annotated.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 5, 2022
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 8, 2022
@rstoyanchev rstoyanchev added this to the 1.0.2 milestone Sep 8, 2022
@rstoyanchev rstoyanchev changed the title @Argument annotation on interfaces is ignored. Support controller method parameter annotations on an interface Sep 8, 2022
@rstoyanchev rstoyanchev self-assigned this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants