Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation points to non existing MVC HTTP sample application #578

Closed
nytro77 opened this issue Dec 13, 2022 · 2 comments
Closed

Documentation points to non existing MVC HTTP sample application #578

nytro77 opened this issue Dec 13, 2022 · 2 comments
Labels
status: duplicate A duplicate of another issue

Comments

@nytro77
Copy link

nytro77 commented Dec 13, 2022

Section 2.1 HTTP points to non existing sample application - https://github.com/spring-projects/spring-graphql/tree/main/samples/webmvc-http

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 13, 2022
@barunmishra13
Copy link

I stumbled upon the same broken links just now. The Readme here says:

The are samples in the 1.0.x branch that will be #208 into a separate repository.

But the documentation has not been updated.

Anyway @nytro77 - the updated link is: https://github.com/spring-projects/spring-graphql/tree/1.0.x/samples/webmvc-http

@bclozel
Copy link
Member

bclozel commented Dec 16, 2022

Thanks for the heads up, this has been fixed in #208 (comment) and will be released with the next release.

The change is already available here: https://docs.spring.io/spring-graphql/docs/current-SNAPSHOT/reference/html/#samples

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2022
@bclozel bclozel added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants