Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of custom DataLoaderRegistry instance #836

Closed
rstoyanchev opened this issue Oct 13, 2023 · 0 comments
Closed

Allow use of custom DataLoaderRegistry instance #836

rstoyanchev opened this issue Oct 13, 2023 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

Currently DefaultExecutionGraphQlService sets the DataLoaderRegistry in ExecutionInput to a new instance because it needs to make registrations, while the default instance in ExecutionInput is a no-op that raises exceptions.

We could improve this by using the DataLoaderRegistry from ExecutionInput provided that it's not the default no-op implementation, or has any registrations, which implies it's not the no-op. This would allow use of alternative DataLoaderRegistry like ScheduledDataLoaderRegistry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant