You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently DefaultSchemaResourceGraphQlSourceBuilder registers a Consumer<GraphQL.Builder> callback to run inspection at the end of the build steps. This is because SchemaMappingInspector depends on the following:
Code registrations in the RuntimeWiring, which is available only in DefaultSchemaResourceGraphQlSourceBuilder#initGraphQlSchema.
Access to GraphQLSchema after it is transformed with type visitors which happens later in the base AbstractGraphQlSource.
The approach works fine if the builder is used once, but has the side effect of registering an additional callback with each call to build(), which hasn't been noticed as the builder is normally used once. However, GraphQlSource was always meant to allow resolving the GraphQL and GraphQLSchema at runtime, and we should remove this side effect.
The text was updated successfully, but these errors were encountered:
Currently
DefaultSchemaResourceGraphQlSourceBuilder
registers aConsumer<GraphQL.Builder>
callback to run inspection at the end of the build steps. This is becauseSchemaMappingInspector
depends on the following:RuntimeWiring
, which is available only inDefaultSchemaResourceGraphQlSourceBuilder#initGraphQlSchema
.GraphQLSchema
after it is transformed with type visitors which happens later in the baseAbstractGraphQlSource
.The approach works fine if the builder is used once, but has the side effect of registering an additional callback with each call to
build()
, which hasn't been noticed as the builder is normally used once. However,GraphQlSource
was always meant to allow resolving theGraphQL
andGraphQLSchema
at runtime, and we should remove this side effect.The text was updated successfully, but these errors were encountered: