Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtle incompatibilities between graphql-java version 20.x and 21.x #882

Closed
svametcalf opened this issue Jan 24, 2024 · 3 comments
Closed
Labels
status: invalid An issue that we don't feel is valid

Comments

@svametcalf
Copy link

Greetings! First off, thanks for the great library!

We ran into a strange bug when upgrading to version 3.2.x of Spring Boot this week. Upgrading from 3.1.8 to 3.2.0 broke our exception resolution for Subscription types. With the upgrade, our previously working SubscriptionExceptionResolver was not being called and subscription exceptions were just being adapted to the generic error message "Subscription error".

I was unable to create a minimal reproducible case with a simple schema / service setup, because the error did not present itself. You can see my attempt to repro the error here: https://github.com/svametcalf/gql-subscription-exceptions-debug.

After some more debugging of our production code, it became apparent that a ContextDataFetcherDecorator was not being registered as the DataLoader for each Subscription type using Spring 3.2.x (and version 21.x of graphql-java). Downgrading the version of graphql-java to 20.x solved the issue for us.

Therefore, it seems that there might be some incompatibilities between the schema traversal mechanism in v20.x and v21.x of graphql-java which may be causing issues for other users.

Unfortunately our schema is quite large and would be hard to debug against but if you have any suggestions for what I can try to make a more minimal repro case, I am happy to help get to the bottom of this issue.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 24, 2024
@bclozel
Copy link
Member

bclozel commented Jan 24, 2024

Hello @svametcalf !

This is a duplicate of #861. For now (and until the next maintenance release), downgrading graphql-java is the easiest workaround.

I'd like to check that your sample works with the latest snapshot before really closing this issue as a duplicate.

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Feb 8, 2024
@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Feb 15, 2024
@spring-projects-issues
Copy link
Collaborator

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@spring-projects-issues spring-projects-issues removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Feb 22, 2024
@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
@bclozel bclozel added the status: invalid An issue that we don't feel is valid label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

3 participants