Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing Map of DataFetcher registrations to SchemaMappingInspector as alternative to RuntimeWiring #894

Closed
rstoyanchev opened this issue Jan 31, 2024 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jan 31, 2024

Currently the inspector expects the GraphQLSchema and RuntimeWiring. This works fine for our purposes since we use RuntimeWiring to addDataFetcher registrations. However, instead of performing direct registrations, alternative GraphQlSource.Builder implementations may also use the GraphQLCodeRegistry in RuntimeWiring, or possibly not use RuntimeWiring at all.

To make the inspector more generally usable we could allow it to take a map of registrations, independent of how or whether RuntimeWiring is used. A map is suffiicent for the internal implementation, in which case the existing method taking RuntimeWiring would become a simple delegate.

@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Jan 31, 2024
@rstoyanchev rstoyanchev added this to the 1.2.5 milestone Jan 31, 2024
@rstoyanchev rstoyanchev self-assigned this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant