Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple ControlledAdvice is not working properly #901

Closed
xmazu opened this issue Feb 7, 2024 · 1 comment
Closed

Multiple ControlledAdvice is not working properly #901

xmazu opened this issue Feb 7, 2024 · 1 comment
Assignees
@bclozel
Labels
type: regression A bug that is also a regression
Milestone
1.2.5

Comments

@xmazu
Copy link

xmazu commented Feb 7, 2024 •
edited
Loading

I can't create multiple @ControlledAdvice classes without adding explicit @Order.

Example project: https://github.com/xmazu/spring-graphql-multiple-controller-advice
I have added tests that should work but with current AnnotatedControllerExceptionResolver implementation they won't 😢
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 7, 2024
@xmazu xmazu mentioned this issue Feb 7, 2024
Closed
@rstoyanchev
Copy link
Contributor

Superseded by #902.

@rstoyanchev rstoyanchev closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
@rstoyanchev rstoyanchev added status: superseded Issue is superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 8, 2024
@rstoyanchev rstoyanchev reopened this Feb 15, 2024
@rstoyanchev rstoyanchev added type: bug A general bug type: regression A bug that is also a regression and removed status: superseded Issue is superseded by another type: bug A general bug labels Feb 15, 2024
@rstoyanchev rstoyanchev added this to the 1.2.5 milestone Feb 15, 2024
@bclozel bclozel self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: regression A bug that is also a regression
Projects
None yet
Milestone
1.2.5
Development

Successfully merging a pull request may close this issue.

Add support for multiple unordered ControlledAdvice xmazu/spring-graphql
4 participants
@bclozel @rstoyanchev @xmazu @spring-projects-issues