Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation with guidance on using virtual threads #907

Closed
vyj7 opened this issue Feb 13, 2024 · 4 comments
Closed

Updated documentation with guidance on using virtual threads #907

vyj7 opened this issue Feb 13, 2024 · 4 comments
Assignees
Labels
type: documentation A documentation task
Milestone

Comments

@vyj7
Copy link

vyj7 commented Feb 13, 2024

I was wondering if we have support to use virtual threads, for batch-loaders as opposed to current use?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 13, 2024
@bclozel
Copy link
Member

bclozel commented Feb 13, 2024

See graphql-java/graphql-java#3331

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Feb 13, 2024

@vyj7 are you aware that SchemaMapping and BatchMapping methods support returning Callable that's invoked through the configured Executor, e.g. VirtualThreadTaskExecutor?

The discussion that Brian referenced would need to progress for deeper support at the level of GraphQL Java, but as it is today, you can use virtual threads.

@vyj7
Copy link
Author

vyj7 commented Feb 13, 2024

We recently migrated from java-kickstart. I have explored spring-graphql very minimal so that migration can be smooth. But this looks promising to me.
Thanks @bclozel @rstoyanchev . I will try doing it.

@rstoyanchev rstoyanchev changed the title Java 21 virtual thread support with spring-graphql Updated documentation with guidance on using virtual threads Feb 13, 2024
@rstoyanchev rstoyanchev self-assigned this Feb 13, 2024
@rstoyanchev rstoyanchev added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 13, 2024
@rstoyanchev rstoyanchev added this to the 1.2.5 milestone Feb 13, 2024
@rstoyanchev
Copy link
Contributor

I'll update the documentation a little to make this easier to find.

@bclozel bclozel modified the milestones: 1.2.5, 1.2.6 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

4 participants