Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust offset based pagination to be exclusive of reference position #916

Closed
rstoyanchev opened this issue Feb 20, 2024 · 1 comment
Closed
Assignees
Labels
type: bug A general bug
Milestone

Comments

@rstoyanchev
Copy link
Contributor

The Relay spec expects scrolling to be exclusive of the referenced position. However, offset based scrolling is inclusive of the reference position and also always scrolls forward.

For forward scrolling we need make an adjustment to advance by 1. We have not been doing that from the beginning, and have been returning items from (and including) the reference position.

For backward scrolling we need to advance back by the count and switch to forward. We had been doing that until 1.2.4 when a change was made based on the report in #840 to advance by 1 extra, which is in fact incorrect. We'll need to go back and investigate #840 again once more, but the adjustment needs to be made to correct the behavior.

@rstoyanchev rstoyanchev added the type: bug A general bug label Feb 20, 2024
@rstoyanchev rstoyanchev added this to the 1.2.5 milestone Feb 20, 2024
@rstoyanchev rstoyanchev self-assigned this Feb 20, 2024
@rstoyanchev
Copy link
Contributor Author

There is now a 1.2.5-SNASPHOT with the changes in https://repo.spring.io/snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant