Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of specific ContextSnapshotFactory instance #919

Closed
rstoyanchev opened this issue Feb 26, 2024 · 2 comments
Closed

Allow use of specific ContextSnapshotFactory instance #919

rstoyanchev opened this issue Feb 26, 2024 · 2 comments
Assignees
@rstoyanchev
Labels
type: enhancement A general enhancement
Milestone
1.3.0-RC1

Comments

@rstoyanchev
Copy link
Contributor

Currently we use private, local instances that rely on ServiceLoader mechanism. However, it would be good to allow use of a specific instance.
@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Feb 26, 2024
@rstoyanchev rstoyanchev added this to the 1.2.6 milestone Feb 26, 2024
@rstoyanchev rstoyanchev self-assigned this Feb 26, 2024
@rstoyanchev
Copy link
Contributor Author

rstoyanchev commented Mar 7, 2024 •
edited
Loading

ContextSnapshotFactory was only added in context-propagation 1.0.3, and we switched to using it recently with 98d39bc in main, effectively raising the baseline for our upcoming 1.3 release. So I'm moving this change to target 1.3 as well.

@rstoyanchev rstoyanchev modified the milestones: 1.2.6, 1.3.0-M2 Mar 7, 2024
@rstoyanchev
Copy link
Contributor Author

Re-considering the approach taken. Exposing setters in many places doesn't seem ideal.

@rstoyanchev rstoyanchev reopened this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.3.0-RC1
Development

No branches or pull requests
1 participant
@rstoyanchev