Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use either first or after to determine forward pagination #929

Closed
rstoyanchev opened this issue Mar 20, 2024 · 2 comments
Closed

Use either first or after to determine forward pagination #929

rstoyanchev opened this issue Mar 20, 2024 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

While investigating #925, I noticed we only check for the presence of last to assume backward pagination, so for a query with only before, we assume forward, and as a result ignore the before argument. The pagination spec does expect both last and before to enable backward pagination, but nevertheless we should check the presence of either last or before

@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Mar 20, 2024
@rstoyanchev rstoyanchev added this to the 1.2.6 milestone Mar 20, 2024
@rstoyanchev rstoyanchev self-assigned this Mar 20, 2024
@GoncaloPT

This comment was marked as off-topic.

@rstoyanchev
Copy link
Contributor Author

The steps to check have been updated to start by looking for either "after" or "first", leading to forward pagination. Then for the presence of either "before" or "last" for backward pagination.

@rstoyanchev rstoyanchev changed the title Use either last or before to enable backward pagination Use either first or after to determine forward pagination Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants