Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt offset scroll calculations to changes in Spring Data 2024.0 #946

Closed
rstoyanchev opened this issue Apr 9, 2024 · 0 comments
Closed
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

Spring Data 2024.0 will align offset with keyset scroll positions in spring-projects/spring-data-commons#3070 such that an offset position corresponds to the element index (i.e. no longer adding +1), and also for data store implementations to exclude rather than include the reference offset position.

This will require follow-up adjustments on our end. For forward pagination we no longer need to advance by 1. For backward pagination, we need to advance back by (count + 1) so the results exclude the reference position.

@rstoyanchev rstoyanchev added the type: dependency-upgrade A dependency upgrade label Apr 9, 2024
@rstoyanchev rstoyanchev added this to the 1.3.0-RC1 milestone Apr 9, 2024
@rstoyanchev rstoyanchev self-assigned this Apr 9, 2024
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed type: dependency-upgrade A dependency upgrade labels Apr 9, 2024
@rstoyanchev rstoyanchev changed the title Adapt offset scroll calculations to upcoming changes in Spring Data 2024.0 Adapt offset scroll calculations to changes in Spring Data 2024.0 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant