-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use HTTP 302 status for UI redirect #1107
Merged
bnasslahsen
merged 1 commit into
springdoc:master
from
d3ns0n:unify-redirect-response-code
Mar 15, 2021
Merged
use HTTP 302 status for UI redirect #1107
bnasslahsen
merged 1 commit into
springdoc:master
from
d3ns0n:unify-redirect-response-code
Mar 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great PR. This one had more impacts on tests ! |
This was referenced Mar 16, 2021
Closed
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bnasslahsen
here is the PR for switching to 302 instead of 307 when using webflux-ui. This PR also contains some cleanups for affected test classes:
Argument 'getResult.getResponseBody()' might be null
by asserting to not nullorg.junit.jupiter.api.Assertions.assertTrue
toorg.assertj.core.api.Assertions.assertThat
for better assertion error output