Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use HTTP 302 status for UI redirect #1107

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

d3ns0n
Copy link
Contributor

@d3ns0n d3ns0n commented Mar 15, 2021

@bnasslahsen

here is the PR for switching to 302 instead of 307 when using webflux-ui. This PR also contains some cleanups for affected test classes:

  • remove never thrown Exceptions from throws list
  • remove IntelliJ warning Argument 'getResult.getResponseBody()' might be null by asserting to not null
  • switch from org.junit.jupiter.api.Assertions.assertTrue to org.assertj.core.api.Assertions.assertThat for better assertion error output

@bnasslahsen
Copy link
Contributor

@d3ns0n,

Great PR. This one had more impacts on tests !
Thank for your help.
We should release the new version v1.5.6, before the end of the week, which will ship your changes as well.

@bnasslahsen bnasslahsen merged commit 2f47250 into springdoc:master Mar 15, 2021
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants