Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include PATCH method in options/cors/methods default #1475

Closed
tracker1 opened this issue Mar 10, 2014 · 1 comment
Closed

Include PATCH method in options/cors/methods default #1475

tracker1 opened this issue Mar 10, 2014 · 1 comment
Assignees
@nlf
Labels
feature New functionality or improvement
Milestone
3.0.0

Comments

@tracker1
Copy link

The reference docs make mention to the options for cors in creation of a new server, and the default methods allowed. I believe this default should include PATCH, especially given that it includes PUT/POST/DELETE.

Given that most modern restful APIs are JSON based, PATCH is much more appropriate than PUT.
@hueniverse hueniverse added this to the 3.0.0 milestone Mar 10, 2014
@nlf nlf closed this as completed in be79511 Mar 11, 2014
hueniverse pushed a commit that referenced this issue Mar 11, 2014
Merge pull request #1476 from nlf/master
ca7c405 
add PATCH to default cors methods, closes #1475
@Marsup Marsup added feature New functionality or improvement and removed request labels Sep 20, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nlf nlf

Labels
feature New functionality or improvement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
4 participants
@hueniverse @nlf @tracker1 @Marsup