Template helpers fail on relative paths

[irothschild]

I have server options that include something like:

            views: {
                engines: {
                    html: 'handlebars'
                },
                basePath: 'foobar',
                path: 'templates',
                defaultExtension: 'html',
                helpersPath: 'helpers',
           }

This works fine for loading the templates but the helpers don't load properly.

My template helpers are in foobar/helpers. In file hapi/lib/views.js Manager.prototype._loadHelpers finds all the helper files properly with paths like foobar/helpers/myhelper.js but then it does a require() on that path which fails to load the file.

Is basePath intended to be a full path?

[hueniverse]

It should be a relative or absolute which means starting with '/' or './'. Let me know if that helps.

[irothschild]

Relative paths don't seem to work because Path.join() strips the leading dot. The only way I could get it to work without code changes is to use an absolute path for basePath.

[hueniverse]

I think your problem is the base path. It needs to be relative to the current working directory. See the two tests I've added showing relative paths working.

[irothschild]

Well this confused me. But in fact the tests are only passing because the helpers have already been successfully required with the absolute path in previous tests. If you move the new relative path tests so they're the first helper tests, they will fail.

22. Views #render loads helpers using relative paths:

  AssertionError: expected undefined to equal '<p>This is all UPPERCASE and this is how we like it!</p>'

[hueniverse]

Interesting...