Remove reference to request in domain. Closes #1634 #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.request.log(['hapi', 'internal', 'implementation', 'error'], err); | ||
| } | ||
| else { | ||
| console.error('Debug: late request implementation error:\n ' + err.stack); |
There was a problem hiding this comment.
Shouldn't this make it to a centralized log rather than console log? We for example don't have those going anywhere and no monitoring to speak of on console.
kpdecker
added a commit
that referenced
this pull request
May 13, 2014
Remove reference to request in domain. Closes #1634
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.