-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle winpty binaries with Python wheels #43
Comments
I succeed on this you could have a look at yawinpty and I also bundled winpty source so that everyone could build source tarball without winpty pre-installed |
@titansnow why did you create another project instead of using contributing to this one? |
because I don't know this project when I first start that one :) when I got to know this project, my project is finished basically |
@andfoy, I think you can put both the exe and dll files in the directory where pywinpty is installed (i.e. in Please try that and let me know how it goes. |
@ccordoba12 Bundling the winpty binaries actually works, I will update the RELEASE file then, also I'll release 0.1.3 |
Please read the comment I left in your PR before merging it. Also, please build a wheel locally and verify that the |
After looking at spyder#4753, I realized that users that install pywinpty without conda might have some problems because they don't have the winpty.dll and winpty-agent.exe binaries on their path. Is it possible to distribute them inside the Wheel package? @ccordoba12
The text was updated successfully, but these errors were encountered: