Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle winpty binaries with Python wheels #43

Closed
andfoy opened this issue Jul 16, 2017 · 6 comments
Closed

Bundle winpty binaries with Python wheels #43

andfoy opened this issue Jul 16, 2017 · 6 comments
Assignees
Milestone

Comments

@andfoy
Copy link
Owner

andfoy commented Jul 16, 2017

After looking at spyder#4753, I realized that users that install pywinpty without conda might have some problems because they don't have the winpty.dll and winpty-agent.exe binaries on their path. Is it possible to distribute them inside the Wheel package? @ccordoba12

@ghost
Copy link

ghost commented Jul 17, 2017

I succeed on this

you could have a look at yawinpty

and I also bundled winpty source so that everyone could build source tarball without winpty pre-installed

@goanpeca
Copy link
Contributor

goanpeca commented Jul 17, 2017

@titansnow why did you create another project instead of using contributing to this one?

@ghost
Copy link

ghost commented Jul 17, 2017

because I don't know this project when I first start that one :)

when I got to know this project, my project is finished basically

@ccordoba12
Copy link
Contributor

ccordoba12 commented Jul 17, 2017

@andfoy, I think you can put both the exe and dll files in the directory where pywinpty is installed (i.e. in site-packages).

Please try that and let me know how it goes.

@ccordoba12 ccordoba12 added this to the v0.1.3 milestone Jul 17, 2017
@andfoy
Copy link
Owner Author

andfoy commented Jul 21, 2017

@ccordoba12 Bundling the winpty binaries actually works, I will update the RELEASE file then, also I'll release 0.1.3

@ccordoba12
Copy link
Contributor

Please read the comment I left in your PR before merging it. Also, please build a wheel locally and verify that the winpty files are inside it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants