Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add appveyor CI integration #29

Merged
merged 6 commits into from
Jun 23, 2017
Merged

PR: Add appveyor CI integration #29

merged 6 commits into from
Jun 23, 2017

Conversation

goanpeca
Copy link
Contributor

@goanpeca goanpeca commented Jun 23, 2017

Fixes #4

@goanpeca goanpeca added this to the v0.1.1 milestone Jun 23, 2017
@goanpeca goanpeca self-assigned this Jun 23, 2017
@goanpeca goanpeca closed this Jun 23, 2017
@goanpeca goanpeca reopened this Jun 23, 2017
@goanpeca goanpeca closed this Jun 23, 2017
@goanpeca goanpeca reopened this Jun 23, 2017
appveyor.yml Outdated
- "activate test"
# Install the selected Qt version
- "conda install --file requirements.txt -c conda-forge"
- "python setup.py install"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use CMD_IN_ENV here. Please take a look at the Spyder yaml file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@goanpeca
Copy link
Contributor Author

goanpeca commented Jun 23, 2017

@andfoy test are running but I am not getting any coverage :-|

screen shot 2017-06-23 at 00 22 45

Also I could not run with python setup.py develop/install so I built the recipe (with conda build) and then installed that one and run pytest from that installed one.

Thoughts?

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

Actually, we're missing some env variables to compile using setuptools, I will add them. By the way, our python packages are not including Cython sources (pyx files), only C transpiled files. Should we include pyx files by default? @goanpeca that's why coverage is not reported when you use conda-build

@goanpeca
Copy link
Contributor Author

Actually, we're missing some env variables to compile using setuptools, I will add them. By the way, our python packages are not including Cython sources (pyx files), only C transpiled files. Should we include pyx files by default? @goanpeca that's why coverage is not reported when you use conda-build

Yes we should...

@andfoy

@goanpeca
Copy link
Contributor Author

Also that last test seems to need to be tweaked cause now it is failing

@goanpeca
Copy link
Contributor Author

@andfoy if you can paste as a message here the env variables needed to use setup tools, I can add them to the process.

And yes I think we need to bundle the cython sources, not only the compiled c ones

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

@goanpeca You need to set LIBRARY_INC=C:\<anaconda path>\envs <If there is an env>\Library\include and LIBRARY_LIB=C:\<anaconda path>\envs <If there is an env>\Library\lib

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

Also, you need to compile Cython sources inplace before testing: python setup.py build_ext -i --compiler=msvc

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

Do not forget also to set DISTUTILS_USE_SDK=1

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

And yes I think we need to bundle the cython sources, not only the compiled c ones

I will open an issue to add PYX sources to the MANIFEST.in

@goanpeca
Copy link
Contributor Author

@andfoy actually, you need to update that on the readme... or create a BUILD.md, to give conda instructions (one line!) vs the other haha.

I prefer to use conda-build in that case, @andfoy you mean that if I include the cython sources, with MANIFEST.in it should work?

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

I prefer to use conda-build in that case, @andfoy you mean that if I include the cython sources, with MANIFEST.in it should work?

Let me confirm it!

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

@andfoy actually, you need to update that on the readme... or create a BUILD.md, to give conda instructions (one line!) vs the other haha.

I will add them, I actually forgot completely about all those variables haha

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

By the way, do not forget to set CYTHON_COVERAGE=1

@goanpeca
Copy link
Contributor Author

Yep that was the one I did set up

@goanpeca goanpeca closed this Jun 23, 2017
@goanpeca goanpeca reopened this Jun 23, 2017
@@ -0,0 +1,3 @@
:: Use cython coverage on build
"%PYTHON%" setup.py build_ext -i --compiler=msvc
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command does not install nothing at all to site-packages, it only compiles all files locally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I just realized XD

appveyor.yml Outdated
# Use test conda environment
- "activate test"
- "conda install --file requirements.txt -c conda-forge"
- "'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\vcvarsall.bat'"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call? Haha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.... :-p

@goanpeca
Copy link
Contributor Author

Ok @andfoy and @ccordoba12 this is ready, great work @andfoy :-)

I need to fix something on coveralls-python, but that is a separate issue

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

Thanks for the great effort! @goanpeca

@ccordoba12
Copy link
Contributor

Great work @goanpeca!

@andfoy
Copy link
Owner

andfoy commented Jun 23, 2017

Should I merge this? @goanpeca

@goanpeca goanpeca merged commit 29af008 into andfoy:master Jun 23, 2017
@goanpeca goanpeca deleted the enh/ci branch June 23, 2017 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants