-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add appveyor CI integration #29
Conversation
appveyor.yml
Outdated
- "activate test" | ||
# Install the selected Qt version | ||
- "conda install --file requirements.txt -c conda-forge" | ||
- "python setup.py install" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use CMD_IN_ENV here. Please take a look at the Spyder yaml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
@andfoy test are running but I am not getting any coverage :-| Also I could not run with Thoughts? |
Actually, we're missing some env variables to compile using |
Yes we should... |
Also that last test seems to need to be tweaked cause now it is failing |
@andfoy if you can paste as a message here the env variables needed to use setup tools, I can add them to the process. And yes I think we need to bundle the cython sources, not only the compiled c ones |
@goanpeca You need to set |
Also, you need to compile Cython sources inplace before testing: |
Do not forget also to set |
I will open an issue to add PYX sources to the MANIFEST.in |
Let me confirm it! |
I will add them, I actually forgot completely about all those variables haha |
By the way, do not forget to set |
Yep that was the one I did set up |
conda.recipe/bld.bat
Outdated
@@ -0,0 +1,3 @@ | |||
:: Use cython coverage on build | |||
"%PYTHON%" setup.py build_ext -i --compiler=msvc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command does not install nothing at all to site-packages
, it only compiles all files locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I just realized XD
appveyor.yml
Outdated
# Use test conda environment | ||
- "activate test" | ||
- "conda install --file requirements.txt -c conda-forge" | ||
- "'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\vcvarsall.bat'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call? Haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.... :-p
Ok @andfoy and @ccordoba12 this is ready, great work @andfoy :-) I need to fix something on coveralls-python, but that is a separate issue |
Thanks for the great effort! @goanpeca |
Great work @goanpeca! |
Should I merge this? @goanpeca |
Fixes #4