Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Do not include binaries in the tarball #78

Merged
merged 3 commits into from
Nov 28, 2017
Merged

PR: Do not include binaries in the tarball #78

merged 3 commits into from
Nov 28, 2017

Conversation

blink1073
Copy link
Collaborator

Fixes #77

@andfoy
Copy link
Owner

andfoy commented Nov 27, 2017

Does removing the exe and dll references on the MANIFEST allows to add them to the binary wheels?

@andfoy andfoy added this to the v0.5.1 milestone Nov 27, 2017
@blink1073
Copy link
Collaborator Author

I was reading up on that. We may need to specifically add package_data.

@blink1073
Copy link
Collaborator Author

I haven't yet figured out how to exclude files from the sdist but not the wheel, will come back to this tomorrow.

@andfoy
Copy link
Owner

andfoy commented Nov 27, 2017

I haven't yet figured out how to exclude files from the sdist but not the wheel, will come back to this tomorrow.

Thanks for the help on this

@blink1073
Copy link
Collaborator Author

Good to go now

@andfoy andfoy merged commit 8602eba into andfoy:master Nov 28, 2017
@ccordoba12 ccordoba12 changed the title Do not include binaries in the tarball PR: Do not include binaries in the tarball Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @andfoy