render type.impl when type is a TypeDecorator instance #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as mentioned in my comment I dont think we want to do this. We definitely get users complaining etc. when their exact type is not rendered, even if they don't need it to be. This seems like a big leap of assumptions to make for not much reason, not the least of which that the column as returned inside the As mentioned in my comment, this particular preference can be suited by a simple type rendering recipe right now for those who really want to control this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When rendering the type, we check to see if we are dealing with a TypeDecorator, and if so, proceed but with type.impl instead... this results in the underlying type from the sqlalchemy package to be rendered into the migration instead of the TypeDecorator (wherever it may be defined).
Fixes: #1386
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!