-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropIndexOp
does not render keyword arguments such as postgresql_concurrently
#849
Comments
will have to look and see if we have existing precedent for this, which I think we should, like for indexes etc. |
looks like you have a fix ready! that's a PR, please send. I assume most of the other constructs are OK in this regard |
Thanks @zzzeek for the triage! Created PR for this. |
thanks for following all the guidelines on this! most people dont :) but it makes it easy |
Jet Zhou has proposed a fix for this issue in the master branch: Add kwargs support to DropIndexOp autogenerate render https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2844 |
thanks! 1.6.5 is released. |
Woohoo! Thanks for taking a look and the quick + efficient PR prorcess! |
Describe the bug
1011366 added kwargs support to drop index operation in SQL generation. However, in autogenerate render step, an operation such as this one:
will be rendered to
which ignores the
postgresql_concurrently
kwarg.Expected behavior
should render in autogenerate to
To Reproduce
Test code that does not pass
Versions.
Additional context
Proposed fix: jetzhou@6392a28
Have a nice day!
The text was updated successfully, but these errors were encountered: