Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-vendor "editor" #856

Closed
zzzeek opened this issue Jun 10, 2021 · 1 comment
Closed

re-vendor "editor" #856

zzzeek opened this issue Jun 10, 2021 · 1 comment
Assignees
Labels
bug Something isn't working command interface
Milestone

Comments

@zzzeek
Copy link
Member

zzzeek commented Jun 10, 2021

the python-editor package now has a deprecation warning:

DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives

project looks to be not maintained since 2019: https://github.com/fmoo/python-editor

a newer package looks to be maintained but has lots of dependencies (two) for what is like a ten line program: https://github.com/rec/editor

this "editor" concern is very trivial and not worth relying upon these come-and-go ten line packages out there so I suggest we re-vendor this. our original impl can be seen in 7b91b32,

@zzzeek zzzeek added bug Something isn't working command interface labels Jun 10, 2021
@zzzeek zzzeek added this to the 1.7 milestone Jun 10, 2021
@CaselIT CaselIT self-assigned this Jun 12, 2021
@sqla-tester
Copy link
Collaborator

CaselIT has proposed a fix for this issue in the master branch:

Revendor editor and make dateutil optional https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working command interface
Projects
None yet
Development

No branches or pull requests

3 participants