Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"warning: conflicting chdir during another chdir block" start showing up in 1.4.0+ version #54

Open
gyfelton opened this issue Mar 24, 2023 · 0 comments

Comments

@gyfelton
Copy link
Member

This is esp. bad if there are multiple submodules for a repo. But it will show up at least once for every git fastclone operation
I believe the real reason is Dir.chdir is not thread safe: https://bugs.ruby-lang.org/issues/9785 but we perform this in order to checkout each module in separate thread. So far not causing any problem because we don't really do much git operation outside the chdir block after we start different threads.
Just to put out the problem here for discussion on how to resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant