-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Golang code for Benchmark #83
Comments
This was discussed many times. The benchmark purpose is comparing single-core performance. Anyway if you are looking for multi core numbers these were done: #14 |
@squeaky-pl - Are you serious ? Above code is single-core performance. But using unwated
Above is your code . Can you see difference ?? Doing same work running on "single-core performance" but code and performance will vary a lot. Especially when getting nodejs result as closer to golang itself looks funny. |
Please compare this with other benchmarks, they all have the same logic for 404. Go won't do this by default so it needs to be added. Otherwise it is unfair. Also reading a global variable will be faster because it reduces pressure on Go garbage collector. |
The particular global variable change was done here: https://github.com/squeaky-pl/japronto/pull/12/files and measured 18% speed up for Go. |
Please fix the golang code for benchmark purpose -
Use Above code and please test the bechmark of
golang
withjapronto
. Same goes withfasthttp
The text was updated successfully, but these errors were encountered: