Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title spacing not rendering correctly in the text generator #2536

Closed
marconmartins opened this issue Jun 20, 2019 · 3 comments
Closed

Title spacing not rendering correctly in the text generator #2536

marconmartins opened this issue Jun 20, 2019 · 3 comments
Milestone

Comments

@marconmartins
Copy link

The following code renders "associative array" as "associativearray" when the text generator is used.

<code_comparison>
    <code title="Valid: Comma after item on their own line (associative array).">
    <![CDATA[
$arr = <em>[</em>
    1 => 'value',
    2 => <em>[</em> 1 <em>]</em>,
    3 => 'c',
<em>]</em>;
        ]]>
    </code>
    <code title="Invalid: Missing comma after item on their own line (associative array)">
    <![CDATA[
$arr = <em>[</em>
    1 => 'value',
    2 => <em>[</em> 1 <em>]</em>,
    3 => 'c'
<em>]</em>;
        ]]>
    </code>
</code_comparison>

Screenshot 2019-06-20 at 13 08 43

@gsherwood
Copy link
Member

I think this was fixed by this commit: 19de461

The fix is unreleased, but it would be great if you could test the fix or latest master.

@jrfnl
Copy link
Contributor

jrfnl commented Jun 26, 2019

I have tested this with @marconmartins' PR and can confirm that 19de461 fixes this, so consider this issue fixed,

@gsherwood
Copy link
Member

Closing. Going to trust @jrfnl on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants