Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should query type be string or array? #15

Open
christianbundy opened this issue Nov 23, 2019 · 2 comments
Open

Should query type be string or array? #15

christianbundy opened this issue Nov 23, 2019 · 2 comments

Comments

@christianbundy
Copy link
Contributor

var Query = {
  type: 'JSONString',
  description: 'the query it self. It should be the format of a map-filter-reduce query',
  optional: false
}

I don't think that this is right, because queries are meant to look like:

[{
  "$filter": {
    "foo": "bar"
  }
}]

This is an array of objects, not a string.

@dominictarr
Copy link
Contributor

that's correct, but if it's a string, it tries to json parse it. otherwise it's quite awkward to write a query from the cli... I guess it should be JSON string or object. the pattern you use in dominictarr/map-filter-reduce#6 works but only for very simple queries

@stale
Copy link

stale bot commented Feb 22, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the stale label Feb 22, 2020
@christianbundy christianbundy self-assigned this Feb 22, 2020
@stale stale bot removed the stale label Feb 22, 2020
@christianbundy christianbundy removed their assignment Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants