Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default daytime band products should be reflectances #707

Open
kathys opened this issue Aug 26, 2024 · 8 comments · May be fixed by #714
Open

Default daytime band products should be reflectances #707

kathys opened this issue Aug 26, 2024 · 8 comments · May be fixed by #714

Comments

@kathys
Copy link
Collaborator

kathys commented Aug 26, 2024

Our boss Liam has requested that Polar2Grid create actual reflectances that include division by the cosine of the solar zenith angle for each of the polar orbiting satellites that we support, including AVHRR and MODIS. This should be the default daytime reflectance band output.

@kathys kathys added this to the Polar2Grid 3.2 milestone Aug 26, 2024
@djhoese
Copy link
Member

djhoese commented Aug 26, 2024

What about geo2grid readers?

@kathys
Copy link
Collaborator Author

kathys commented Aug 27, 2024

I will speak to Graeme about the defaults for G2G.

@djhoese
Copy link
Member

djhoese commented Aug 27, 2024

My plan for implementing this would be to make "aliases" for all channels requested from the command line that are visible channels. In Satpy terms, they would be an alias for DataQuery(name="<channel name>", modifiers=("sunz_corrected",)). This should mean that any existing composites will not be affected.

In normal software versioning terms, I'm tempted to say this is almost a "major" change deserving of a 4.0 release but I suppose it doesn't have to be. Just something that popped in my head when thinking about this last night.

@kathys
Copy link
Collaborator Author

kathys commented Aug 27, 2024

I understand why you would say this. I think it will also add processing time too. But I think it is the right thing to do, and Liam is right in that our users, especially in the polar regions, will get uniform images across sensors. An important part of this change will be to make sure that I document it well for end users.

@djhoese
Copy link
Member

djhoese commented Aug 27, 2024

Any idea if there are any readers (AVHRR?) where we don't have access to solar zenith angles and they would have to be computed on-the-fly from the lon/lats? That would take the processing time hit from insignificant to extremely annoying.

@djhoese
Copy link
Member

djhoese commented Sep 25, 2024

Just to have it written down for future reference, the readers affected by this are:

  • viirs_sdr Files come with sunz applied
  • viirs_l1b
  • modis_l1b
  • mersi2_l1b
  • avhrr_l1b_aapp

Any others? Did we ask Graeme about Geo2Grid?

@djhoese
Copy link
Member

djhoese commented Sep 27, 2024

I should note that for readers/files where SZA is not available at every resolution, there will be a required resampling step that will now take longer because of needing to resample not just band data but also the SZA. One example is mersi2 where SZA is available at 1km but some bands are available at 250.

@djhoese djhoese linked a pull request Sep 27, 2024 that will close this issue
@kathys
Copy link
Collaborator Author

kathys commented Sep 27, 2024

Understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@djhoese @kathys and others