load munin::node::plugin_share_dir via automatic lookup #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when `munin::plugin` uses `lookup()` directly, this effectively means the variable value is unavailable to auxilliary classes which need to install additional files in the plugin directory. the patch removes the other occurences of `lookup()` too, since they only complicate the code, and potentially cause an inconsistency if the user passes value into `munin::node` via explicit parameters rather than via Hiera.
kenyon
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
munin::pluginuseslookup()directly, this effectively means the variable value is unavailable to auxilliary classes which need to install additional files in the plugin directory.the patch removes the other occurences of
lookup()too, since they only complicate the code, and potentially cause an inconsistency if the user passes value intomunin::nodevia explicit parameters rather than via Hiera.