Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for output before downloading models #139

Closed
ssube opened this issue Feb 14, 2023 · 0 comments
Closed

check for output before downloading models #139

ssube opened this issue Feb 14, 2023 · 0 comments
Labels
status/fixed issues that have been fixed and released type/bug broken features
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Feb 14, 2023

With the changes to the convert script to allow https sources, the fetch_model call happens before the converter, but the converter is responsible for skipping conversion if the output files already exist. Because the download happens before the check, you cannot convert and then remove ckpt/safetensors files, and have to keep the unused copy in the cache (or an empty file of the same name).

@ssube ssube added status/new issues that have not been confirmed yet type/bug broken features labels Feb 14, 2023
@ssube ssube added this to the v0.7 milestone Feb 14, 2023
@ssube ssube added status/progress issues that are in progress and have a branch and removed status/new issues that have not been confirmed yet labels Feb 14, 2023
@ssube ssube closed this as completed in 7f6fa22 Feb 14, 2023
@ssube ssube added status/fixed issues that have been fixed and released and removed status/progress issues that are in progress and have a branch labels Feb 14, 2023
@ssube ssube mentioned this issue Feb 14, 2023
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/fixed issues that have been fixed and released type/bug broken features
Projects
None yet
Development

No branches or pull requests

1 participant