Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support graceful shutdown #400

Closed
6 of 7 tasks
Tracked by #357
sbernauer opened this issue Oct 9, 2023 · 0 comments · Fixed by #402
Closed
6 of 7 tasks
Tracked by #357

Support graceful shutdown #400

sbernauer opened this issue Oct 9, 2023 · 0 comments · Fixed by #402
Assignees

Comments

@sbernauer
Copy link
Member

sbernauer commented Oct 9, 2023

Part of stackabletech/issues#357

Must

  • Code goes into rust/operator-binary/src/operations/graceful_shutdown.rs (if needed)
  • Update docs/modules/<operator>/pages/usage-guide/operations/graceful-shutdown.adoc
  • Functionality verified manually by restarting Pods
  • Graceful shutdown period must be configurable, probably on roleGroup config (see CRD changes tab). Implementation is copied from trino-operator and uses human-readable time.
  • Sane default for graceful shutdown period determined
  • smoke test tests default value

Should

  • Integration test added, e.g. something like chaos monkey in hdfs. This is probably the hardest part of the whole task, so it's a "Should"
@sbernauer sbernauer moved this from Next to Ready for Development in Stackable Engineering Oct 9, 2023
@sbernauer sbernauer moved this from Ready for Development to Development: Waiting for Review in Stackable Engineering Oct 11, 2023
@sbernauer sbernauer self-assigned this Oct 11, 2023
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Progress in Stackable Engineering Oct 11, 2023
@sbernauer sbernauer moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Oct 12, 2023
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 19, 2023
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Nov 3, 2023
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants