Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize how we display terminal/bash code blocks #1190

Closed
wileyj opened this issue Jun 7, 2021 · 7 comments
Closed

Standardize how we display terminal/bash code blocks #1190

wileyj opened this issue Jun 7, 2021 · 7 comments
Assignees
Labels
chore Has to be done but not fun. enhancement Improvement of existing feature or aspect. stale

Comments

@wileyj
Copy link
Contributor

wileyj commented Jun 7, 2021

We have prior art where we've typically used a code block like this to show terminal or bash commands:

$ echo "test string"

However, Akirtovskis mentioned in stacks-network/stacks-blockchain-docker#39 that it would make things easier to remove the $ from terminal/bash, like this:

echo "test string"

Personally, I agree with this approach - the only reason I had added the $ is because of prior docs/readme's that we've published where the $ exists.

To keep this issue easily scoped, we should go through existing docs here and remove the $ or any other shell/terminal identifier ( % is another example).
Later, it would be nice to work on a style-guide that we use here with the goal of standardizing how we create docs with the goal of making them easy and accessible. ( @pgray-hiro )

@wileyj wileyj added chore Has to be done but not fun. enhancement Improvement of existing feature or aspect. labels Jun 7, 2021
@Akirtovskis
Copy link

Happy to jump in and help with PRs that remove $ and % in docs if some sort of list or scope of repositories is provided.

@pgray-hiro
Copy link
Contributor

@Akirtovskis I would certainly love the assistance - I want to just put it to our dev team to make sure this is how we want to standardize, once we've sorted that out I can provide a resource list

@pgray-hiro
Copy link
Contributor

@Akirtovskis After internal discussion and discussion with the community, we've settled on not including the $ or % terminal prompt in any docs or READMEs. There is one exception to this rule, if the code block is showing the command and the example output of the command for example:

$ stx balance SP2JM9EMVHHRHWHW82CD9XQMTYTM8BG2RWG58WQVB
{
  "balance": "18588980982",
  "locked": "0",
  "unlock_height": 0,
  "nonce": 1609
}

In the above case it would be acceptable to leave as is, or as a best practice it would be preferred to split the example command and the output with some expository text between them.

As far as doc updates go, this repo would be the primary target, but we would appreciate additional PRs on READMEs in any repo in the blockstack organization. Let me know if this is something you can take on.

@Akirtovskis
Copy link

Akirtovskis commented Jun 9, 2021

@pgray-hiro I am definitely up for doing this!

@stale
Copy link

stale bot commented Dec 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 7, 2021
@stale
Copy link

stale bot commented Dec 15, 2021

This issue has been automatically closed. Please reopen if needed.

@stale stale bot closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Has to be done but not fun. enhancement Improvement of existing feature or aspect. stale
Projects
None yet
Development

No branches or pull requests

3 participants