You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As noted here, this decision was made in an effort to keep things DRY, but on the contrary this may be introducing an anti-pattern for maintaining Dockerfiles and some misdirection, which may make it more difficult to contribute or debug CI workflows for those unfamiliar with the process.
It may make more sense in this case to create a separate Dockerfile specifically for the Stacks Signer image. Despite the small amount of duplication added, it may make it easier for others to understand the CI and release process.
The text was updated successfully, but these errors were encountered:
It's worth looking into. I'm also not a fan of piping the commands the dockerfiles are running to a shell script, then CMD ["sh", "-c", "/tmp/command.sh"]
Currently, a single Dockerfile is used to create the image for both the Stacks Node and Stacks Signer by using special logic at the end of the file to determine which binary it should run.
As noted here, this decision was made in an effort to keep things DRY, but on the contrary this may be introducing an anti-pattern for maintaining Dockerfiles and some misdirection, which may make it more difficult to contribute or debug CI workflows for those unfamiliar with the process.
It may make more sense in this case to create a separate Dockerfile specifically for the Stacks Signer image. Despite the small amount of duplication added, it may make it easier for others to understand the CI and release process.
The text was updated successfully, but these errors were encountered: