Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider creating a separate Dockerfile for the Stacks Signer #4990

Open
CharlieC3 opened this issue Jul 22, 2024 · 1 comment
Open

Consider creating a separate Dockerfile for the Stacks Signer #4990

CharlieC3 opened this issue Jul 22, 2024 · 1 comment
Assignees

Comments

@CharlieC3
Copy link
Member

Currently, a single Dockerfile is used to create the image for both the Stacks Node and Stacks Signer by using special logic at the end of the file to determine which binary it should run.

As noted here, this decision was made in an effort to keep things DRY, but on the contrary this may be introducing an anti-pattern for maintaining Dockerfiles and some misdirection, which may make it more difficult to contribute or debug CI workflows for those unfamiliar with the process.

It may make more sense in this case to create a separate Dockerfile specifically for the Stacks Signer image. Despite the small amount of duplication added, it may make it easier for others to understand the CI and release process.

@wileyj
Copy link
Contributor

wileyj commented Jul 22, 2024

It's worth looking into. I'm also not a fan of piping the commands the dockerfiles are running to a shell script, then CMD ["sh", "-c", "/tmp/command.sh"]

echo "/bin/stacks-signer run --config /signer-config.toml" > /tmp/command.sh \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

3 participants