Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bitcoin ops always include a change address #4992

Closed
obycode opened this issue Jul 22, 2024 · 2 comments
Closed

Ensure bitcoin ops always include a change address #4992

obycode opened this issue Jul 22, 2024 · 2 comments

Comments

@obycode
Copy link
Contributor

obycode commented Jul 22, 2024

The Bitcoin transactions generated by the Stacks miner must always have a change address. If there is no change address, then the op is treated as invalid. In testnet/stacks-node/src/burnchains/bitcoin_regtest_controller.rs, we need to ensure that this is the case.

Background: naka-1 stalled after a restart and it was discovered that the VRF key register was invalid because it had no change address while the node expected 2 outputs: the OP_RETURN and the change.

@ASuciuX
Copy link
Contributor

ASuciuX commented Aug 2, 2024

Should this be closed as the PR got merged?

@janniks janniks closed this as completed Aug 2, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

5 participants