Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If signers rollover (new cycle, different signers); Miner shouldn’t accept sigs from “old”/previous set of signers - Integration Test #5215

Closed
Tracked by #5133
ASuciuX opened this issue Sep 20, 2024 · 1 comment
Assignees
Labels

Comments

@ASuciuX
Copy link
Contributor

ASuciuX commented Sep 20, 2024

Could be part of the mine_2_nakamoto_reward_cycles or an extended version of it. It should verify in the second reward cycle that the blocks are not signed by the signers that were in the first reward cycle (and aren't anymore).

Update: there is one integration test doing this exact flow here - signer_set_rollover.

Update 2: after analyzing multiple PRs and looking for signer_set_rollover CI run, this integration test is working in the latest develop as expected.

@ASuciuX ASuciuX changed the title If signers rollover (new cycle, different signers); Miner shouldn’t accept sigs from “old”/previous set of signers; (Integration) If signers rollover (new cycle, different signers); Miner shouldn’t accept sigs from “old”/previous set of signers - Integration Test Sep 20, 2024
@ASuciuX ASuciuX self-assigned this Sep 20, 2024
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Sep 20, 2024
@ASuciuX ASuciuX closed this as completed Sep 24, 2024
@github-project-automation github-project-automation bot moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng Sep 24, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

No branches or pull requests

2 participants