Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signer] Add a configurable timeout to signers for how long to wait for the last block of a tenure to be accepted before allowing its reorg #5423

Open
jferrant opened this issue Nov 4, 2024 · 0 comments
Assignees

Comments

@jferrant
Copy link
Collaborator

jferrant commented Nov 4, 2024

It is very possible at tenure boundary that signers can enter into a state of limbo due to poorly time block commits relative to the prev tenures last block proposal. To avoid this chainstall, we enable the reorg of the prior locally accepted block. However, there are times where the prior block WOULD reach global acceptance but its just a little delayed. In which case we actually reorg a valid block that if we just waited a bit the chain would not be stalled. Add a timeout to minimize this reorg of a globally accepted block happening. If a proposal does not get globally rejected/approved within x amount of time at the tenure boundary, time it out and start signing a sibling block from the new tenure instead. This will minimize the reorg of a GLOBALLY accepted block. Default it to 30 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

1 participant