-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display VR scene under Enter VR button #169
Comments
Hi @smrghsh more detail would be helpful here. You could consider adding small drawings or notes about implementation. Also further explanation on why this is important, existing precedents, etc. A macro feature issue is a prime place to keep detailed notes and plans. |
@stalgiag, I've updated with more detail and a plan. |
I was able to load an inline session and then launch immersive with the immersive web inline example on desktop as well as quest. Currently studying that functionality, and will try to emulate that, because it accomplishes this goal. The process should be even simple as in almost all instances, an inline XR session should start first. |
looks great! |
closed with #171 |
Nature of issue?
Which area does this problem relate to?
New feature details:
Aims to start the sketch in a browser canvas before Enter VR button is clicked and display the Enter VR button over the sketch, so a user can see the scene before entering VR
The idea behind this feature request is to provide users with a preview of the VR experience that they are about to enter. This provides several advantages. This allows a user to see the initial scene, potentially giving a 'hook' or encouragement to entry, like a thumbnail. Since VR can be very intense and consuming, this also can provide a 'heads up' to the user before they enter a 3D space. For a developer, this allows for a quicker view of the starting environment, potentially speeding up iteration cycles of debugging.
Currently, I believe p5xr does this in order to provide a button that launches the XR experience.
This feature request draws inspiration from the way three.js projects often provide VR. However, it does not support inline XR or AR; it only supports
immersive-vr
. I have noted that it doesn't support an exit VR button.It also does not support inline xr. Originally, in order to address this, I was trying to load inline XR because it functions as the 2D preview. However, this doesn't work on headset, as headset browsers inform p5xr that they are immersive, and I get errors with the refSpace. Therefore, I propose something like the following. The approach is to render the scene without XR, perform a session check and label button appropriately, and then have the button start the sketch over.
In this way, logic that handles whether the experience is VR or AR is kept out of p5vr.
The diagrams can be small without zooming in to the images, so I've included a figma link for easier viewing:
Figma Link
@stalgiag
The text was updated successfully, but these errors were encountered: