Extends ComponentOptions with `ability` member #73

bebsworthy · 2018-06-04T10:57:39Z

This fix a typescript error when following the tutorial:

Code:

import { abilitiesPlugin } from '@casl/vue'
import Vue from 'vue';
import ability from './ability'

new Vue({
  router,
  store,
  ability,
  render: (h) => h(App),
}).$mount('#app')

Error:

[ts]
Argument of type '{ router: VueRouter; store: Store<{}>; ability: Ability; render: (h: CreateElement) => VNode; }' is not assignable to parameter of type 'ComponentOptions<Vue, DefaultData<Vue>, DefaultMethods<Vue>, DefaultComputed, PropsDefinition<Rec...'.
  Object literal may only specify known properties, and 'ability' does not exist in type 'ComponentOptions<Vue, DefaultData<Vue>, DefaultMethods<Vue>, DefaultComputed, PropsDefinition<Rec...'.

Allows: ```ts import { abilitiesPlugin } from '@casl/vue' import Vue from 'vue'; import ability from './ability' new Vue({ router, store, ability, render: (h) => h(App), }).$mount('#app') ```

codecov-io · 2018-06-04T11:02:58Z

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          16       16           
  Lines         284      284           
=======================================
  Hits          283      283           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cadcb73...f49dc80. Read the comment docs.

stalniy · 2018-06-04T11:47:48Z

Awesome :) Thanks for contribution!

Allows: ```ts import { abilitiesPlugin } from '@casl/vue' import Vue from 'vue'; import ability from './ability' new Vue({ router, store, ability, render: (h) => h(App), }).$mount('#app') ```

stalniy · 2018-06-04T11:51:45Z

published @casl/[email protected]

Extends ComponentOptions with ability member

f49dc80

Allows: ```ts import { abilitiesPlugin } from '@casl/vue' import Vue from 'vue'; import ability from './ability' new Vue({ router, store, ability, render: (h) => h(App), }).$mount('#app') ```

stalniy merged commit 90e2fb3 into stalniy:master Jun 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extends ComponentOptions with `ability` member #73

Extends ComponentOptions with `ability` member #73

bebsworthy commented Jun 4, 2018

codecov-io commented Jun 4, 2018 •

edited

Loading

stalniy commented Jun 4, 2018

stalniy commented Jun 4, 2018

Extends ComponentOptions with ability member #73

Extends ComponentOptions with ability member #73

Conversation

bebsworthy commented Jun 4, 2018

codecov-io commented Jun 4, 2018 • edited Loading

Codecov Report

stalniy commented Jun 4, 2018

stalniy commented Jun 4, 2018

Extends ComponentOptions with `ability` member #73

Extends ComponentOptions with `ability` member #73

codecov-io commented Jun 4, 2018 •

edited

Loading