Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning support to Snazzy to allow Standard 17 #29

Open
tagliala opened this issue Jun 3, 2022 · 4 comments · May be fixed by #32
Open

Add warning support to Snazzy to allow Standard 17 #29

tagliala opened this issue Jun 3, 2022 · 4 comments · May be fixed by #32

Comments

@tagliala
Copy link

tagliala commented Jun 3, 2022

Do you know which package is in charge of building this json?

{
  line: '2',
  column: '17',
  message: 'Expected property shorthand.',
  ruleId: 'object-shorthand) (warning'
}

If this is not being created by Snazzy (as it appears to my eyes, I'm not a JavaScript developer), I think that there could be an issue somewhere else upstream that should be fixed before adding warning support to Snazzy

Originally posted by @tagliala in standard/eslint-config-standard#229 (comment)
@tagliala tagliala changed the title Do you know which package is in charge of building this json? Add warning support to Snazzy to allow Standard 17 Jun 3, 2022
@tagliala tagliala mentioned this issue Jun 22, 2022
Closed
@xChickens
Copy link

@voxpelli Any chance you could take a look at this?

tagliala added a commit to tagliala/standard-json that referenced this issue May 1, 2023
@tagliala
Add warning support
3a07e14 
Ref: standard/snazzy#29
tagliala added a commit to tagliala/snazzy that referenced this issue May 1, 2023
@tagliala
Add warning support
1864aec 
Close standard#29
@tagliala tagliala linked a pull request May 1, 2023 that will close this issue
Draft
@tagliala
Copy link
Author

tagliala commented May 1, 2023 •
edited
Loading

Hello,

this requires a combination of 2 PRs:

#32 needs to be adjusted by deciding what it is needed to do with warnings

image

I would be glad if you can continue my PRs. standard/standard-json#14 is also tested, but you may not like the implementation

@tagliala
Copy link
Author

Friendly bump.

Since standard seems still supported, after the recent 17.1.0 release, it may be a good moment to also upgrade snazzy and standard-json

@voxpelli
Copy link
Member

Since standard seems still supported, after the recent 17.1.0 release, it may be a good moment to also upgrade snazzy and standard-json

I did those releases as I still used those modules + found some time in my calendar.

I don’t use either of snazzy or standard-json and I’m not having time to help out maintaining standard much anymore, so you would have check with @feross

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
The Standard Project
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add warning support tagliala/snazzy
3 participants
@voxpelli @tagliala @xChickens