Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual steps to be coded up #19

Open
antoinefalisse opened this issue Sep 24, 2024 · 2 comments · May be fixed by #22
Open

Manual steps to be coded up #19

antoinefalisse opened this issue Sep 24, 2024 · 2 comments · May be fixed by #22
Assignees

Comments

@antoinefalisse
Copy link
Collaborator

antoinefalisse commented Sep 24, 2024

@sashasimkin these are the three steps we/I had to do manually to get things to work, could we "include" them in terraform instead? I would suggest we do it on the OpenCap side (parent project).

  1. Add internet gateway to subnets
  2. Add policy to retrieve secrets to ecs-task-execution-role
  3. Create S3 bucket (https://github.com/stanfordnmbl/opencap-infrastructure/blob/main/production/backend.tf#L3)

If you see other critical steps after what we discussed, please fell free to suggest any changes that you think should be implemented (eg, for security reasons)

Thanks

@sashasimkin
Copy link
Collaborator

hey @antoinefalisse , thanks for listing these!

It would take me approximately 1 hr to implement these + 30 mins to scan the code and list possible critical failures.

Additionally, we'll need a meeting of around 1hr after I've implemented these to bring the resources that were created AdHoc under terraform management.

I should be able to complete these before EOW, however might expect a few delays depending on my workload.

Lmk if I should proceed.

@antoinefalisse
Copy link
Collaborator Author

Hey @sashasimkin, thanks. Please go for it.

@sashasimkin sashasimkin linked a pull request Oct 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants