Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] GQL imageCreate schema still accepts url #727

Open
feederbox826 opened this issue Nov 1, 2023 · 0 comments · May be fixed by #736
Open

[Bug Report] GQL imageCreate schema still accepts url #727

feederbox826 opened this issue Nov 1, 2023 · 0 comments · May be fixed by #736
Labels
help wanted Extra attention is needed

Comments

@feederbox826
Copy link

Describe the bug
the imageCreate mutation still accepts URL when only path should be affected

To Reproduce
query:

mutation imageCreate {
    imageCreate(
        input: {
            url: "https://upload.wikimedia.org/wikipedia/commons/6/66/SMPTE_Color_Bars.svg"
        }
    ) {
        id
    }
}

error:

{
    "errors": [
        {
            "message": "Missing URL or file",
            "path": [
                "imageCreate"
            ]
        }
    ],
    "data": {
        "imageCreate": null
    }
}

stash-box-config.yml

...
image_backend: file
image_location: /images

Expected behavior
GQL imageCreate should be updated to omit URL input instead of responding with a misleading error message

Additional context
confirmed by infinite in discord

I can try to poke around the GQL myself and submit a PR

@feederbox826 feederbox826 added the help wanted Extra attention is needed label Nov 1, 2023
feederbox826 added a commit to feederbox826/stash-box that referenced this issue Dec 11, 2023
@feederbox826 feederbox826 linked a pull request Dec 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant