-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Making manual tagging more efficient when defining Scene markers #1011
Comments
If this is added, it needs to be optional. |
$40 bounty added. |
I've been thinking about extending the "Tags" filter with choices for where to search for the tag. So that on the scenes list when adding the tag filter you can opt to search for the tag on the scene, and/or a marker and/or a performer. So instead of having two or three tag filters (currently two, one for "Tags" and one for "Performer tags" you add a tag filter and select to search the tag on the scene, or performer, or both (or marker)). My use case for this would be for example hair color tags which can be applied to performers, but mostly is also added to a scene during scraping. So you could then just search for "Blond hair", check scene and performer and you get all scenes where either the scene or one of the performers has that tag. Would that work for you as well? As you could then search for tag "Bouncing", select scene and scene markers to search for the tag and it would also list all scenes where the tag is (only) applied to a marker. |
I am hoping to meet the requirements of this issue using a plugin mentioned in #1452 rather than extending the core code. Implementing this feature in the core system is a pretty simple affair, but my main hang up with it is that it adds another configuration key to the list. There may be similar requests for adding tags from performers when adding a performer to a scene - to use a contrived example. Rather than adding configuration flags for all these specific behaviours, I think it's better to defer this behaviour to plugins, to allow users to extend the behaviour of the core system to their liking. Embedded javascript plugins, and now plugin hooks allows us to add this functionality without polluting the settings pages with niche behaviour flags. I'm hoping that this will be an acceptable compromise @ALonelyJuicebox The implementation of the plugin itself is available as an attachment to #1452 |
@gitgiggety Hey I actually like that UX change, and it simplifies the dropdown. @WithoutPants Agreed. I'm a hobby dev at best-- whatever sounds more reasonable to implement. Agreed with your secondary example as it's another thing I'd actually love to see added. 😅 |
Correct, that's what I'm thinking about adding. Obviously with Scenes, Performers, and Markers being checkboxes which you can enable on an individual basis. |
If tags are added to a marker on a scene, please set those same tags to the scene itself.
This avoids a scenario where tagging requires the tagging of the marker as well as duplicating that same tagging effort on the scene itself.
Current scenario: Scene Marker is set at 10:15 with a primary tag of "bouncing". User has to then also click on the Edit tab and manually also add in the "Bouncing" tag to the scene
Ideal scenario: Scene Marker is set at 10:15 with a primary tag of "bouncing". Tag is added to both the marker and the scene.
Thanks! 🙏
The text was updated successfully, but these errors were encountered: